Fix errors in GH action coverage test #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran this code after the fixes and it works fine now. Tested scripts:
However, when I open root is this expected behaviour? |
|
I think it's normal when DB is empty. Running |
dqunbp
reviewed
Dec 6, 2023
REQUIREMENTS.txt
Outdated
| Whoosh==2.5.6 | ||
|
|
||
| # Updates for Django 2 & Python 3.7 | ||
| git+https://github.com/Xpirix/whoosh.git |
There was a problem hiding this comment.
Wouldn't it be better to specify a specific commit?
dqunbp
reviewed
Dec 6, 2023
dockerize/docker/Dockerfile
Outdated
| @@ -12,7 +12,7 @@ RUN echo "deb http://archive.debian.org/debian stretch main contrib non-free" > | |||
| RUN apt-get update && apt-get install -y libsasl2-dev python-dev libldap2-dev libssl-dev | |||
| ADD REQUIREMENTS.txt /REQUIREMENTS.txt | |||
| RUN pip install -r /REQUIREMENTS.txt | |||
| RUN pip install uwsgi | |||
| RUN pip install uwsgi freezegun | |||
There was a problem hiding this comment.
Wouldn't it be better to specify a specific version?
dqunbp
reviewed
Dec 6, 2023
dockerize/docker/REQUIREMENTS.txt
Outdated
| django-haystack | ||
|
|
||
| # Updates for Django 2 & Python 3.7 | ||
| git+https://github.com/Xpirix/whoosh.git |
dqunbp
reviewed
Dec 6, 2023
qgis-app/REQUIREMENTS_plugins.txt
Outdated
| django-haystack | ||
|
|
||
| # Updates for Django 2 & Python 3.7 | ||
| git+https://github.com/Xpirix/whoosh.git |
|
@dqunbp . Thanks for the feedback. Yes, I also think it's better to specify the commit or the version to prevent errors in the future. I've just made these fixes. |
dimasciput
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this PR:
django-taggit, 'Whoosh', 'picke5') in requirements to fix errors when running tests or commands in a development environment<div class="span8 new-feedback">becomes<div class="new-feedback">because<div class="span8 new-feedback">doesn't exist and the test will always fail.